Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver API versioning fixes #207

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Driver API versioning fixes #207

merged 2 commits into from
Feb 14, 2022

Conversation

gnosek
Copy link
Contributor

@gnosek gnosek commented Feb 14, 2022

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area driver-kmod

/area driver-ebpf

/area libscap

/area libsinsp

/area tests

/area proposals

What this PR does / why we need it:

The driver API versioning PR (#39) got a few important things wrong:

  • the bit-twiddling calculations were completely wrong and also had a copy-paste error
  • the value returned from the new ioctls in kmod was truncated to 32 bits and effectively useless

This PR fixes them.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@gnosek
fix: fix bit twiddling macros for API versioning support
6a37024 
Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
@gnosek
fix: pass API versions from kmod via pointer, not return value
55b7f8c 
The return value is limited to 32 bits, which chops off most
high-order bits.

Signed-off-by: Grzegorz Nosek <grzegorz.nosek@sysdig.com>
@poiana poiana requested review from leogr and mstemm February 14, 2022 15:36
FedeDP
FedeDP approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes absolutely sense.
/approve

@poiana poiana added the lgtm label Feb 14, 2022
@poiana
Copy link
Contributor

poiana commented Feb 14, 2022

LGTM label has been added.

Git tree hash: 5773cb852ca6f7069cb232a2ac70772eb3babd87

leogr
leogr approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

/approve

@poiana poiana merged commit 8e2a574 into falcosecurity:master Feb 14, 2022
@poiana
Copy link
Contributor

poiana commented Feb 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, gnosek, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [FedeDP,gnosek,leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@leogr leogr leogr approved these changes

@mstemm mstemm Awaiting requested review from mstemm

Assignees

@leogr leogr

@FedeDP FedeDP

Labels
approved area/driver-kmod area/libscap dco-signoff: yes kind/bug Something isn't working lgtm release-note-none size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnosek @poiana @leogr @FedeDP